Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call add_to_transaction on #restore! as well #297

Open
wants to merge 1 commit into
base: rails4
Choose a base branch
from

Conversation

Empact
Copy link
Contributor

@Empact Empact commented Jan 13, 2016

Under certain conditions, combining the use of paranoia and
counter_culture can result in callbacks not being run. This is
perhaps due to an interaction between after_commit_action and
user-defined after_commit callbacks, but unfortunately I have been
unable to pin this down in tests.

Note this makes restore! roughly symmetric with delete/destroy in
its existing use of add_to_transaction.

Under certain conditions, combining the use of paranoia and
counter_culture can result in callbacks not being run. This is
perhaps due to an interaction between after_commit_action and
user-defined after_commit callbacks, but unfortunately I have been
unable to pin this down in tests.

Note this makes restore! roughly symmetric with delete/destroy in
its existing use of add_to_transaction.
@Empact
Copy link
Contributor Author

Empact commented Jan 13, 2016

I made some fairly extensive efforts to repro under test then gave up. What do you guys think?

@brigade-gerrit brigade-gerrit deleted the add-to-transaction branch January 28, 2016 03:18
@shosti
Copy link

shosti commented Feb 8, 2016

BTW this will probably be affected by #274 (and should have a fix similar to #309).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants